Re: [PATCH] gui/configure.ac -- wrong inclusion paths

[Kazunobu Kuriyama]

Adam Fedor wrote:

> On Tuesday, February 17, 2004, at 11:00 PM, Kazunobu Kuriyama wrote:
>
> > Hi,
> >
> > Due to the wrong order of the inclusion paths set by configure.ac,
> > cpp first includes the gui's header files in $(GNUSTEP_SYSTEM_ROOT),
> > not in the source tree. This may cause a compilation failure if a
> > header file installed there is not consistent with the one coming
> > with the source.
> CPPFLAGS shouldn't be included in the final output of configure 
> anyway, it's just there for use of configure. This problem seems like 
> it is due to the recent check for X. Can you see if this patch fixes 
> it instead:
I confirmed your patch fixes it. 

But the part

@@ -172,9 +172,6 @@
  AC_MSG_ERROR(gnustep-gui will not compile without tiff)
fi

-ADDITIONAL_INCLUDE_DIRS="ADDITIONAL_INCLUDE_DIRS $GRAPHIC_CFLAGS"
-ADDITIONAL_LIB_DIRS="ADDITIONAL_LIB_DIRS $GRAPHIC_LFLAGS"

is not the one I added recently, so I'm not completely sure we can
safely remove these two lines.  IMO, they are redundant for checking
the audiofile stuff, but appear they were put there in order to
enable us to check the png stuff in a more elaborated way in future
when we need such a elaboration (e.g. detection of .a/.so/.h files
installed in non-standard locations).

Regards,
- Kazunobu Kuriyama