Re: [bugs #8498] [MinGW] NSUnarchiver crashes

[Richard Frith-Macdonald]

On 10 Apr 2004, at 03:09, Gregory John Casamento wrote:

> Wim,
>
> In the directory:
>
> gnustep/dev-apps/test/gormtest
>
> There is an application which extensively tests .gorm functionality.
>
> GJC
> --- Wim Oudshoorn <woudshoo@xs4all.nl> wrote:
> > Gregory John Casamento <greg_casamento@yahoo.com> writes:
> >
> > > All,
> > >
> > > Initial tests indicate that this breaks .gorm loading for some 
> > > reason.   I
> > need
> > > to do further tests.   I recommend not adding this patch until this 
> > > problem
> > has
> > > been investigated and cleared.
> > >
> > > GJC
> >
> >
> > Thanks for testing, is there a simple testcase which I can
> > run as well?

The supplied patch didn't retain/release objects in all cases where 
they are added to
and removed from the map ... which could have very nasty effects when 
the map was
emptied at the end of unarchiving.

I updated CVS with a version of the code which (afaik) does the 
rating/release correctly.
I tested that against some of my own software, and against Wim's test 
program.

I couldn't properly test against gnustep/dev-apps/test/gormtest since 
the AppDelegate.m
file is missing from CVS and the app wouldn't build ... however I did 
hack in enough code
to get it to build and run without crashing., so I'm pretty confident 
of the fix.
If the fix causes problems, please revert it.