[patch #3498] Fix some parameter names in C function definitions

[Adam Fedor]

This mail is an automated notification from the patch tracker
 of the project: GNUstep.

/**************************************************************************/
[patch #3498] Latest Modifications:

Changes by: 
                Adam Fedor <fedor@gnu.org>
'Date: 
                Thu 11/11/2004 at 03:33 (US/Mountain)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
              Status | Open                      | Closed







/**************************************************************************/
[patch #3498] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3498>
Project: GNUstep
Submitted by: Patrick Middleton
On: Tue 11/02/2004 at 14:57

Category:  AppKit
Priority:  5 - Normal
Resolution:  Invalid
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Closed


Summary:  Fix some parameter names in C function definitions

Original Submission:  Because of what appears to be a known bug/misfeature in 
the ObjC compiler, type information associated with parameter names in function 
definitions is remembered and causes compilation errors when the same parameter 
names are used with different type in ObjC method definitions.

Parameter names are optional in C function definitions, but not in inline 
function declarations or in in ObjC method definitions, so I chose to adopt 
lengthy clumsy descriptive names implying type information.  This probably does 
not conform to GNU coding recommendations and is going to look hideous if 
processed by eg 'headerdoc'.  But it compiles.

I was using the MinGW compiler etc provided by the recent base-1.10.0 installer 
on WinXP SP1.

(There is a small amount of similar trouble elsewhere; one of the base-1.10.0 
objc headers contains one function for which a parameter name 'm' has not been 
removed, and this causes problems when compiling NSPortMessage.[hm].)



Follow-up Comments
------------------


-------------------------------------------------------
Date: Fri 11/05/2004 at 16:39       By: Patrick Middleton <patrickx>
Cough.

It appears my problem report was thoroughly bogus, and the patch I submitted is 
redundant.  In order to get out some macro definition information, I added -dM 
to ADDITIONAL_OBJCFLAGS.  Except what I actually added was -Dm .  I'd have 
realised my error sooner, except that I saw the problem I was describing 
several years ago with the NeXT-supplied gcc 2.7.2.1.  Still, it makes a novel 
argument against the use of single-letter variable names.

Grin?


-------------------------------------------------------
Date: Thu 11/04/2004 at 20:13       By: Fred Kiefer <FredKiefer>
I never heard of such a compiler bug. Could you please give an expample of the 
error you are getting? I have been compiling GNUstep wiht various gcc releases 
on both Linux and Windows (with Cygwin though) and never did get such a 
warning/error.
The patch itself is fine with me, I would just like to understand why it is 
needed.






File Attachments
-------------------

-------------------------------------------------------
Date: Tue 11/02/2004 at 14:57  Name: AppKit-function-definitions.patch  Size: 
78.56KB   By: patrickx
Patch against gnustep-gui-0.9.4
http://savannah.gnu.org/patch/download.php?item_id=3498&amp;item_file_id=3845






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3498>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/