[bugs #11600] [NSSavePanel -browser:isColumnValid:] doesn't detect missing files

[Alexander Malmberg]

This is an automated notification sent by Savannah.
It relates to:
                bugs #11600, project GNUstep

==============================================================================
 OVERVIEW of bugs #11600:
==============================================================================

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11600>

                 Summary: [NSSavePanel -browser:isColumnValid:] doesn't
detect missing files
                 Project: GNUstep
            Submitted by: alexm
            Submitted on: Fri 01/14/05 at 15:53
                Category: Gui/AppKit
                Severity: 3 - Ordinary
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open

    _______________________________________________________


[NSSavePanel -browser:isColumnValid:] currently only checks that all
filenames in the column are valid according to the delegate's
-panel:shouldShowFilename: method. Thus, it won't notice if there are files
in the directory that should be shown but aren't (e.g. because the disk
contents changed, or because the delegate's filtering became more
permissive).



(Reproduce e.g. with a save panel with a file type popup with entries "All
files" and "*.txt only". Go to a directory with non-*.txt files, switch to
"*.txt only", switch back to "All files", and the non-*.txt files won't be
displayed.)



Since this method is only called from -validateVisibleColumns, and since a
proper check here involves reading in the directory, building a new list of
files, and comparing, I think we might as well return NO always and just
reload the column. However, due to NSBrowser internals, this would cause us
to lose the selection every time the columns are validated. Probably best to
have NSBrowser preserve the selection, though.



(this is "tests/gui/NSSavePanel/setDelegate_reload.m" in the 'new' test
suite)








==============================================================================

This item URL is:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11600>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/