[bug #14775] NSRulerView displays it's labels in vertical mode somewhat incorrectly

[Sašo Kiselkov]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=14775>

                 Summary: NSRulerView displays it's labels in vertical mode
somewhat incorrectly
                 Project: GNUstep
            Submitted by: diablos
            Submitted on: Thu 10/13/05 at 09:38
                Category: Gui/AppKit
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open

    _______________________________________________________

Details:

An NSRulerView displays it's number labels when displaying in vertical mode
somewhat incorrectly: their _right_ edge has a constant offset from the
_left_ edge of the ruler. This, however, causes problems when the numbers
reach large values, such as 1000 or 10000, because the first few digits
extend beyond the ruler's left edge and are not visible anymore. As such, the
user cannot tell whether what he/she sees is '444', '4444' or something far
larger - the first digits simply don't fit anymore. Enlarging the ruler's
thickness doesn't help, because of the constant offset.

The problem is located in NSRulerView.m:756:
labelPosition.x =  baselineLocation + LABEL_MARK_SIZE + 4 - size.width;

I propose replacing the line with:
labelPosition.x = baselineLocation + _ruleThickness - size.width;

which will make the labels 'aligned to the right', so when making the ruler
thicker the label's right edges will stay stuck to the right edge of the
ruler, thus allowing larger values to be visible.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=14775>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/