[bug #15112] NSToolbar has wrong behaviour in IconOnly and LabelOnly modes (patch attached)

[Wolfgang Sourdeau]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15112>

                 Summary: NSToolbar has wrong behaviour in IconOnly and
LabelOnly modes (patch attached)
                 Project: GNUstep
            Submitted by: wolfgang
            Submitted on: mer 30.11.2005 à 16:49
                Category: Gui/AppKit
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open

    _______________________________________________________

Details:

This patch was already posted to bug-gnustep. Reposted here for correct bug
management practice.

This patch fixes the following problems:

GSToolbarView:
- the generated menus for toolbars were given entries for unlabelled
  standard items: separators, spaces and flexible spaces

NSCell:
- whenever the cell type would change, the _contents ivar would be set
  to @"title". I changed it to do that only when _contents is unset.
  Besides, I was not sure if setting @"title" was very useful but I let
  it that way in case there was a reason. This fixes the case where
  NSToolbar with displayMode set to LabelOnly would redefine the item
  labels to "title".

NSToolbarItem:
- in GSToolbarButton's layout method:
  the size for the cell of labelled toolbar items would take the label
  size into account even when the toolbar display mode was set to
  IconOnly.
- in NSToolbarItem's initWithItemIdentifier: method:
  a double negation in the test on itemIdentifier was causing the item
  to never be reinited to a GSToolbarSeparatorItem.






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: mer 30.11.2005 à 16:49  Name: toolbarfixes.diff  Size: 6,19Ko   By:
wolfgang
fixes for the bugs mentioned above
<http://savannah.gnu.org/bugs/download.php?item_id=15112&item_file_id=3153>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15112>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/