patch for fixes in NSToolbar and related

[Wolfgang Sourdeau]

Hi,


This patch fixes the following problems:

GSToolbarView:
- the generated menus for toolbars were given entries for unlabelled
  standard items: separators, spaces and flexible spaces

NSCell:
- whenever the cell type would change, the _contents ivar would be set
  to @"title". I changed it to do that only when _contents is unset.
  Besides, I was not sure if setting @"title" was very useful but I let
  it that way in case there was a reason. This fixes the case where
  NSToolbar with displayMode set to LabelOnly would redefine the item
  labels to "title".

NSToolbarItem:
- in GSToolbarButton's layout method:
  the size for the cell of labelled toolbar items would take the label
  size into account even when the toolbar display mode was set to
  IconOnly.
- in NSToolbarItem's initWithItemIdentifier: method:
  a double negation in the test on itemIdentifier was causing the item
  never to be reinited to a GSToolbarSeparatorItem.



Wolfgang
-- 
"An eye for an eye only makes the world blind." (Gandhi)

toolbarfixes.diff
Description: Text document