Re: Fix, NSMatrix -deselectAllCells

[Fred Kiefer]

Alex Perez wrote:
> Georg Fleischmann wrote:
>> Hi,
>>
>> here is a patch for [NSMatrix -deselectAllCells] to set the selected 
>> row/column of an empty matrix always to -1 (even if in radio mode
>> empty  selection is not allowed).
>> This is needed to have the correct starting point after a renew, since
>> adding  a row does not check whether the selected row/column is within
>> the allowed  range.
>>
>> Best wishes,
>> Georg
>>
>>
>> 2006-01-13  Georg Fleischmann
>>     * gui/Source/NSMatrix.m [NSMatrix -deselectAllCells]:
>>       set _selectedRow/_selectedCol = -1 for an empty matrix,
>>       even if empty selection is not allowed.
>>
>>
>> *** gui/Source/NSMatrix.m.old    2005-12-10 18:34:36.000000000 +0100
>> --- gui/Source/NSMatrix.m    2006-01-13 17:49:31.000000000 +0100
>> ***************
>> *** 1043,1049 ****
>>   {
>>     int        i;
>>
>> !   if (!_allowsEmptySelection && _mode == NSRadioModeMatrix)
>>       return;
>>
>>     for (i = 0; i < _numRows; i++)
>> --- 1043,1050 ----
>>   {
>>     int        i;
>>
>> !   if (_numRows > 0 && _numCols > 0 &&
>> !       !_allowsEmptySelection && _mode == NSRadioModeMatrix)
>>       return;
>>
>>     for (i = 0; i < _numRows; i++)
> 
> Did any of the devs ever analyze/submit this?
> 

Yes, I did. Check SVN and the CVS mailing list.

Fred