bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6286] NSBezierPath encode/decode improperly implemented


From: Fred Kiefer
Subject: [patch #6286] NSBezierPath encode/decode improperly implemented
Date: Tue, 27 Nov 2007 17:43:41 +0000
User-agent: Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.7 (like Gecko) SUSE

Update of patch #6286 (project gnustep):

                Priority:                7 - High => 5 - Normal             
             Assigned to:                    None => FredKiefer             

    _______________________________________________________

Follow-up Comment #1:

Thank you for the nice patch, but before applying it I would like to
understand some details.

In your error message I can see that an NSKeyedArchiver gets used. As far as
I can see, your patch doesn't implement the missing keyed archiving for
NSBezierPath, so how does it help you?

In my code NSBezierPathElement is always an enumeration, why would the
encoding stuff need the additional hint that it really is an enum? As far as I
can see there is no struct called NSBezierPathElement.

The usage of encodePoint: is surely nice, but in NSCoder it is just defined
as

- (void) encodePoint: (NSPoint)point
{
  [self encodeValueOfObjCType: @encode(NSPoint) at: &point];
}

How should that make any difference? Apart from readability of course. It may
make a difference for keyed encoding though.

It could well be that your patch works around limitations of the keyed
encoding in base. We better should know about these, before we hide them.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6286>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]