Re: Fix GDL2, PostgreSQLExpression (+formatValue:forAttribute:): writing of escaped strings

[David Ayers]

Thanks ....

Georg Fleischmann schrieb:

> here is a fix for GDL2, PostgreSQLExpression.m
> (+formatValue:forAttribute:).
> The patch allows writing the quote character "'" and encoded characters
> to PostgreSQL 8.3. This has been tested on Mac OS 10.4, so far.
> 
> The changes in detail:
> 1. \' has to be '' to work without Warning message from the sql server
>    WARNING:  nonstandard use of \' in a string literal
>    LINE 14: ', 'User\'s Guide', ...
>                ^
>    HINT:  Use '' to write quotes in strings, or use the escape string
> syntax (E'...').

... for the patch, Georg!
... for committing, Matt!

> 2. the cString copy (tempString) of string doesn't work with encodings,
>    because the cString has different length and character positions as
> the NSString.
>    Additionally on Mac OS, the cString is not always save from being
> updated when
>    changing the corresponding NSString!
>    The suggested solution simply uses [NSString -characterAtIndex:]
> without the cString copy.
> 

Matt has mentioned that this part should already fixed.  Please let us
know if there are any issues left.

Cheers,
David