Re: [bug #25327] NSAnimation no longer works

[Benhur Stein]

On Fri, Jan 16, 2009 at 1:07 PM, Richard Frith-Macdonald <rfm@gnu.org> wrote:
>
> On 16 Jan 2009, at 11:33, Benhur Stein wrote:
>
>> If someone looks into NSAnimation, it is worth reviewing its memory
>> management.
>> I tried to use NSAnimation some time ago, and gave up because it was
>> leaking memory.
>> I did a quick look at it at the time, and there is a retain cycle
>> between NSAnimation and
>> GSAnimator. When I broke this (by removing the retaining of
>> NSAnimation in GSAnimator),
>> I just went a bit further until another retain cycle, and I gave up as
>> I did not have enough time,
>> and changed my code to not use it. My intention was to come back and
>> try harder to find
>> this or at least file a bug report, but I did neither...
>
> Thanks ... I filed a bug report for you ... though I don't know when anyone
> will get to deal with it.
> Do you recall what the memory leaks were related to?  It would be great if
> you could provide the source for a little test app to demonstrate the
> problem, but if it's all too long ago to remember, don't bother.
>

Thanks.
It was more than a year ago, I do not recall exactly, but it had
somthing to do with
the way the animator used timers, there was a retain cycle in there
too, but the
nsanimator code was too complicated for a quick investigation.
I see that the code has been simplified, maybe the problem I had is gone.
The code I had that used NSAnimator was altered to use timers, and it
no longer exists.
I recall however that the problem showed up because it used lots of nsanimators
(allocated a new one for each animation, that was released soon after
the animation
ended).
Sorry for not having more info than that...

Benhur