Re: Fix, GDL2, PostgreSQLExpression (+formatValue:forAttribute:)

[David Ayers]

Am Montag, den 01.06.2009, 12:36 +0800 schrieb Georg Fleischmann:
> here is a small suggestion for GDL2 (with PostgreSQL 8.3). PostgreSQL  
> is complaining about escaping the underscore "_" character.
> I removed the escaping the underscore and everything looks fine.
> 
> 2009-05-29 13:51:38.772 Import[3297] PostgreSQLAdaptor: execute command:
> SELECT  t0.entity_name FROM unique_key t0 WHERE t0.entity_name =  
> 'serial\_number'
> WARNING:  nonstandard use of escape in a string literal
> LINE 1: ...ty_name FROM unique_key t0 WHERE t0.entity_name = 'serial 
> \_n...

Thanks Georg!

I've cleaned it up a bit and committed your patch.   Let us know if you
have any other issues.

Cheers,
David


> *** EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m.old    
> 2008-04-04 13:30:41.000000000 +0800
> --- EOAdaptors/PostgreSQLAdaptor/PostgreSQLExpression.m       2009-05-29  
> 14:16:51.000000000 +0800
> ***************
> *** 343,360 ****
>                {
>                  switch (tempString[i])
>                    {
> !             case '\'':
> !               [string insertString: @"'" atIndex: dif + i];
>                      dif++;
>                      break;
>                    case '\\':
>                      [string insertString: @"\\" atIndex: dif + i];
>                      dif++;
>                      break;
> !                 case '_':
> !                   [string insertString: @"\\" atIndex: dif + i];
> !                   dif++;
> !                   break;
>                    default:
>                      break;
>                    }
> --- 343,360 ----
>                {
>                  switch (tempString[i])
>                    {
> !                 case '\'':
> !                   [string insertString: @"'" atIndex: dif + i];
>                      dif++;
>                      break;
>                    case '\\':
>                      [string insertString: @"\\" atIndex: dif + i];
>                      dif++;
>                      break;
> !                 //case '_':
> !                 //  [string insertString: @"\\" atIndex: dif + i];
> !                 //  dif++;
> !                 //  break;
>                    default:
>                      break;
>                    }
> 
> 
> 
> _______________________________________________
> Bug-gnustep mailing list
> Bug-gnustep@gnu.org
> http://lists.gnu.org/mailman/listinfo/bug-gnustep