[bug #30537] The NSShiftKeyMask bit in modifierFlags during -flagsChanged:

[Derek Fawcus]

URL:
  <http://savannah.gnu.org/bugs/?30537>

                 Summary: The NSShiftKeyMask bit in modifierFlags during
-flagsChanged:
                 Project: GNUstep
            Submitted by: dfawcus
            Submitted on: Sat 24 Jul 2010 09:20:08 AM GMT
                Category: Backend
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

As noted in the source comments the X state flags are updated after a key
press/release,  and as such they cannot be relied upon to indicate the correct
Openstep modifier state (as the modifier changes).  However despite this,  the
code does depend upon the X state for the shift keys.

As such,  a shift press results in flagsChanged: being invoked with the
NSShiftKeyMask bit clear,  and a shift release in an invocation with the bit
set.

The fix is obvious,  namely to treat the shift modifier in the same manner as
the other modifers (control/command/alternate).

Suggested diffs are attached,  along with a program which demonstrates the
issue.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 24 Jul 2010 09:20:10 AM GMT  Name: EvK.tar.gz  Size: 5kB   By:
dfawcus
Suggested diffs and demonstration program.
<http://savannah.gnu.org/bugs/download.php?file_id=21046>
-------------------------------------------------------
Date: Sat 24 Jul 2010 09:20:09 AM GMT  Name: Shift-Fix.gdiff  Size: 4kB   By:
dfawcus
Suggested diffs and demonstration program.
<http://savannah.gnu.org/bugs/download.php?file_id=21045>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30537>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/