[bug #33181] (WebServer 1.4.0) WebSerber`s -_audit: is called 3 times per 1 request

[T.Somequare]

URL:
  <http://savannah.gnu.org/bugs/?33181>

                 Summary: (WebServer 1.4.0) WebSerber`s -_audit: is called 3
times per 1 request
                 Project: GNUstep
            Submitted by: tsomeqdev
            Submitted on: 2011年04月30日 02時42分37秒
                Category: Libraries
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I think The WebServer class has a delegate method "webAudit:for:" for
logging a distinct access like the  Apache`s access_log.
But this is called 3 times per 1 access.
This method seems, there are multiple referrers listed bellow:
  WebServer -(void)_endConnect:(WebServerConnection*)connection
  WebServerConnection - (void) _didWrite: (NSNotification*)notification
  WebServerConnection - (void) end

This causes 2 useless lines. they offten print incomplete string like "- -
-".
And calling respondsToSelector: @selector(webAudit:for:) are also .

I have an idea;
 Currently the WebServerConnection`s -audit returns an instance of NSString.
This NSString* consists of informations like timestamp, address, user-agent,
and so on.
 I think it is better to return an object of class newly created to hold
logging record.
 And it implements methods indicates each information...
@interface WebServerLogRecord
-(NSString*)address;
-(NString*)agent;
-(NSDate*)date;
...
Then, additionally the "-phase" method to return a state end reading/connect/
end writing.
-(WebServerPhase)phase;

What about this?






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?33181>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/