[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #33181] (WebServer 1.4.0) WebSerber`s -_audit: is called 3 times pe
|
From: |
Richard Frith-Macdonald |
|
Subject: |
[bug #33181] (WebServer 1.4.0) WebSerber`s -_audit: is called 3 times per 1 request |
|
Date: |
Thu, 05 May 2011 10:15:57 +0000 |
|
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-us) AppleWebKit/533.21.1 (KHTML, like Gecko) Version/5.0.5 Safari/533.21.1 |
Follow-up Comment #3, bug #33181 (project gnustep):
> I thought this change would enable the delegate to log string in its own
format.
Only if we added new API for this (or broke all existing code using the
library) ... I don't think it's enough of an advantage unless a lot of people
want to do it.
> This is a loss of performance, isn`t it ?
Technically yes, but in practice it's so tiny as to be unimportant. However,
I added caching of the results of the test for the audit method (since it's
always called at least once per request). However, it's arguable that none of
the four tested delegate methods should be cached this way ... any performance
gain is tiny and code which explicitly calls -respondsToSelector: immediately
before using the selector might be clearer.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?33181>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/