[bug #35583] GS_ATTRIB_PRIVATE definition missing led to failure building base

[Graham Lee]

URL:
  <http://savannah.gnu.org/bugs/?35583>

                 Summary: GS_ATTRIB_PRIVATE definition missing led to failure
building base
                 Project: GNUstep
            Submitted by: leeg
            Submitted on: Tue 21 Feb 2012 11:23:46 AM GMT
                Category: Base/Foundation
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Having applied the patch at #35557 to configure GNUstep base extensions with
the apple-apple-apple library combo, I then found that I couldn't build the
library using svn trunk at r34801. The error was this:

#...
In file included from NSFileHandle+GNUstepBase.m:31:
.././GSNetwork.h: In function ‘GSPrivateSockaddrHost’:
.././GSNetwork.h:102: error: expected declaration specifiers before
‘GS_ATTRIB_PRIVATE’
#...

The patch below addresses this build error. I'm not sure that I #include this
file in the correct place in the header for the style guide; please advise if
I should correct that.


Index: Source/GSNetwork.h
===================================================================
--- Source/GSNetwork.h  (revision 34801)
+++ Source/GSNetwork.h  (working copy)
@@ -98,6 +98,8 @@
 #  endif
 #endif
 
+#import "GSPrivate.h"
+
 NSString*
 GSPrivateSockaddrHost(struct sockaddr *addr) GS_ATTRIB_PRIVATE;
 





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?35583>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/