[bug #37939] NSNetService simple boolean logic bug

[Marcus Müller]

URL:
  <http://savannah.gnu.org/bugs/?37939>

                 Summary: NSNetService simple boolean logic bug
                 Project: GNUstep
            Submitted by: znek
            Submitted on: Sun 16 Dec 2012 08:51:54 PM GMT
                Category: Base/Foundation
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

-[NSNetService getInputStream:outputStream] accidentaly fails if either
inputStream or outputStream pointer parameters are NULL (which is legal for
either one).

The fix is simple:


Index: Source/NSNetServices.m
===================================================================
--- Source/NSNetServices.m      (revision 35898)
+++ Source/NSNetServices.m      (working copy)
@@ -281,7 +281,7 @@
                  inputStream: inputStream
                 outputStream: outputStream];
   
-  return inputStream && outputStream;
+  return inputStream || outputStream;
 }
 
 /*





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37939>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/