[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug #34752] compiling with clang gives warnings about unsupported o
From: |
Jean-Charles BERTIN |
Subject: |
Re: [bug #34752] compiling with clang gives warnings about unsupported options |
Date: |
Mon, 04 Mar 2013 14:21:17 +0100 |
Ok, let's stop the flamewar and forget about the quote stuff. Can we
re-focus on the main goal of the patch that is to detect if clang
compiler is in use and remove -shared-libgcc option if it the case.
What do you think of that? Am I wrong with the way I implement it?
Regards.
On Mon, 2013-03-04 at 08:06 -0500, Robert Slover wrote:
> I had declined to reply to this, since the response seemed a bit hostile for
> what was only a benign suggestion. However, since this is specifically being
> discussed, here are the general reasons I suggested the approach that I did:
>
> 1) I most often encounter this sort of issue in code that isn't a string of
> English text containing a contraction. "Plain good english" will not suffice
> to prevent a regular expression or embedded quote in a sed or awk expression
> from tripping up Emacs.
> 2) In the products I work on, user-visible messages will show up in
> documentation, screenshots, and other places. There is always resistance to
> changing message output based on this reason alone. My convenience, as one of
> the few Emacs users, will generally not be considered a sufficient
> justification for a change. Unless I visit the code frequently I will
> generally remove my little "martian style comment" myself before submitting
> such code for review, which is the lowest-impact method of dealing with the
> issue.
> 3) In some of our older code, the original English format strings are used as
> keys in message translation for internationalization purposes. Changing them
> has significant overhead associated with it.
>
> Best regards,
>
>
> --Robert
>
> On Mar 4, 2013, at 4:19, Richard Frith-Macdonald
> <richard@tiptree.demon.co.uk> wrote:
>
> >
> > On 28 Feb 2013, at 10:08, Jean-Charles BERTIN wrote:
> >
> >> What is the best way of correcting this: write plain good english or add
> >> a martian style comment? You decide.
> >
> > Stylistically, the best english output here is to use the contraction. In
> > english, contractions should be used except where there is specific reason
> > not to.
> >
> > ie, "it's" is to be preferred over "it is", since the latter is read as
> > emphasising "is". This unusual emphasis breaks the flow of reading as it
> > prompts the reader to look for the reason for the emphasis; which is good
> > if there is a reason, but poor if there isn't.
> >
--
Jean-Charles BERTIN
Axinoe - Software Engineer
Tel.: (+33) (0)1.80.82.59.23
Fax : (+33) (0)1.80.82.59.29
Skype: jcbertin
Web: <http://www.axinoe.com/>
Certificate Authority: <https://ca.axinoe.com/axinoe-root.crt>
smime.p7s
Description: S/MIME cryptographic signature