[bug #39087] Various format specifier problems cause build to fail

[Graham Lee]

URL:
  <http://savannah.gnu.org/bugs/?39087>

                 Summary: Various format specifier problems cause build to
fail
                 Project: GNUstep
            Submitted by: leeg
            Submitted on: Mon 27 May 2013 08:21:05 PM GMT
                Category: gsweb
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I'm using clang (from Xcode 4.6.2), and building GSW on the Apple platform.
The build has -Werror specified, and many of the build errors that ensue are
due to format specifiers not matching the type being substituted.

There are other problems too, but I've fixed those in a separate patch because
there's something to discuss here. A lot of the format specifier problems
relate to use of NSUInteger in printf-style strings: the Apple clang build
doesn't like that because NSUInteger can be different lengths on their
different platforms (unsigned int on 32-bit, unsigned long on 64-bit).

Apple recommend using %lu and casting the argument to (unsigned long), which
is the route I've chosen in the attached patch. I _assume_ that's appropriate
on every platform GNUstep/GSWeb supports, but wanted to explicitly flag the
fact that I'd made this decision in preparing the patch.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 27 May 2013 08:21:05 PM GMT  Name: gsw-formatspecifiers.patch  Size:
15kB   By: leeg

<http://savannah.gnu.org/bugs/download.php?file_id=28188>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39087>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/