[bug #39299] PostgreSQL adaptor not linking correctly

[Graham Lee]

URL:
  <http://savannah.gnu.org/bugs/?39299>

                 Summary: PostgreSQL adaptor not linking correctly
                 Project: GNUstep
            Submitted by: leeg
            Submitted on: Thu 20 Jun 2013 02:47:41 PM GMT
                Category: gdl2
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

config.mak specifies -lEOControl -lEOAccess, which doesn't work when these are
Mach-O frameworks. The GNUmakefile for the adaptor already tells -make to link
these libraries anyway via ADDITIONAL_NATIVE_LIBS, so this entry is
redundant.

This patch also removes some ambiguity from the log message generated to help
diagnose this issue.

Index: EOAccess/EOAdaptor.m
===================================================================
--- EOAccess/EOAdaptor.m        (revision 36733)
+++ EOAccess/EOAdaptor.m        (working copy)
@@ -225,10 +225,11 @@
   if(adaptorClass == Nil)
     {
       [NSException raise: NSInvalidArgumentException
-                  format: @"%@ -- %@ 0x%x: value of EOAdaptorClassName '%@' is 
not a valid
class and bundle does not contain a principal class",
+                  format: @"%@ -- %@ 0x%x: value of EOAdaptorClassName '%@' 
for adaptor
'%@' is not a valid class and bundle does not contain a principal class",
                   NSStringFromSelector(_cmd),
                   NSStringFromClass([self class]),
                   self,
+                  adaptorClassName,
                   name];
     }
       
Index: EOAdaptors/PostgreSQLAdaptor/config.mak.in
===================================================================
--- EOAdaptors/PostgreSQLAdaptor/config.mak.in  (revision 36733)
+++ EOAdaptors/PostgreSQLAdaptor/config.mak.in  (working copy)
@@ -27,8 +27,7 @@
 ADDITIONAL_INCLUDE_DIRS += @POSTGRES_INCLUDES@
 
 # Libraries linked to the framework
-LIBRARIES_DEPEND_UPON += @POSTGRES_LIBS@ -lEOControl -lEOAccess $(FND_LIBS)
\
-                          $(OBJC_LIBS)
+LIBRARIES_DEPEND_UPON += @POSTGRES_LIBS@ $(FND_LIBS) $(OBJC_LIBS)
 
 # Additional library directories the linker should search
 ADDITIONAL_LIB_DIRS += @POSTGRES_LIB_DIRS@





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39299>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/