bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #47618] NSPredicate: SELF implemented incorrectly


From: Richard Frith-Macdonald
Subject: [bug #47618] NSPredicate: SELF implemented incorrectly
Date: Sun, 9 Apr 2017 08:58:06 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Update of bug #47618 (project gnustep):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => In Test                

    _______________________________________________________

Follow-up Comment #1:

While I'm not very familiar with the NSPredicated code, and don't use it
myself, I've made some changes to at least fix the specific case mentioned.

It looked to me like the primary issue is that [GSEvaluatedObjectExpression
expressionValueWithObject:context:] was returning self rather than its
ageument, so I changed that.
It also failed to implement -keyPath ... causing an exception in the parser.
Also, the key path parsing was failing to realise that the case of SELF.foo
actually means the key path is just 'foo'.

Finally your example comparison failed because the value in the dictionary was
a string.   I guess that the <, >, <= and >= operators are supposed to be
numeric, so I changed the code to use -doubleValue for the arguments to those
operators.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47618>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]