[bug #58190] NSLocale/general.m test still fails with ICU >= 65

[Yavor Doganov]

URL:
  <https://savannah.gnu.org/bugs/?58190>

                 Summary: NSLocale/general.m test still fails with ICU >= 65
                 Project: GNUstep
            Submitted by: yavor
            Submitted on: Thu 16 Apr 2020 04:54:04 PM EEST
                Category: Base/Foundation
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This was initially reported at https://github.com/gnustep/libs-base/issues/103
and fixed in commit 5248b6e.  Unfortunately the fix doesn't work when building
in a chroot (as is the case for the Debian package) because Locale.canonical
is not installed when the testsuite is being run.  Therefore I propose to use
the new locale identifier as in the attached patch and as suggested by user
xnox in the issue above.  It should work with all supported ICU versions.

If the old mapping needs to be tested as well, it may be done as an additional
test marked as hopeful or guarded by the appropriate ICU version check.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 16 Apr 2020 04:54:04 PM EEST  Name:
0001-Use-new-locale-identifier-for-NSLocale-test-should-w.patch  Size: 1KiB  
By: yavor

<http://savannah.gnu.org/bugs/download.php?file_id=48848>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58190>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/