bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #59204] NSOperationQueue leak


From: Larry Campbell
Subject: [bug #59204] NSOperationQueue leak
Date: Tue, 29 Sep 2020 17:50:40 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15

Follow-up Comment #3, bug #59204 (project gnustep):

Looks like this bug was added by this commit:

commit 7380e850e4745282806e62320df5c016bfd4f31e
Author: Richard Frith-Macdonald <rfm@gnu.org>
Date:   Tue Dec 4 11:09:18 2018 +0000

    minor whitespace tidyups


The relevant part of that commit is:

@@ -973,11 +963,8 @@ - (void) _thread
            {
              NSAutoreleasePool *opPool = [NSAutoreleasePool new];
 
-             if (NO == [op isCancelled])
-               {
-                 [NSThread setThreadPriority: [op threadPriority]];
-                 [op main];
-               }
+              [NSThread setThreadPriority: [op threadPriority]];
+              [op start];

Changing "[op start]" back to "[op main]" fixes the leak.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59204>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]