[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29668: grep patches for "Binary file FOO matches" glitches
From: |
Jim Meyering |
Subject: |
bug#29668: grep patches for "Binary file FOO matches" glitches |
Date: |
Fri, 18 Sep 2020 07:05:48 -0700 |
On Thu, Sep 17, 2020 at 7:59 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> On 9/17/20 3:03 PM, Jim Meyering wrote:
> > The alternative is to change that "B" to a "b", which should be fine,
> > now that it's only emitted to stderr.
>
> Makes sense.
>
> NEWS should be updated accordingly - but when I looked into doing that I came
> up
> with the attached more-elaborate patch, which changes this new diagnostic and
> two other unusual-format diagnostics, so that they use the same "grep:
> FILENAME:
> MESSAGE" form that grep uses everywhere else. Whaddya think?
Nice. Dropping the quote module (even if negligible size delta) is a
fine side effect. You're welcome to push that.
Thanks!