bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug in groff 1.17 with Sun C++ compiler


From: Albert Chin-A-Young
Subject: Bug in groff 1.17 with Sun C++ compiler
Date: Fri, 20 Apr 2001 03:13:43 -0500
User-agent: Mutt/1.1.12i

src/devices/grohtml/html-text.h has the prototype for emit_space:
    int    emit_space     (void);

Yet, in src/devices/grohtml/html-text.cc, we have:
  int html_text::emit_space (void)
  {
    if (space_emitted) {
      if (is_present(PRE_TAG)) {
        do_emittext(" ", 1);
      }
    } else {
      out->space_or_newline();
      space_emitted = TRUE;
    }
  }

So, does emit_space need to return anything? According to
src/devices/grohtml/post-html.cc:
      current_paragraph->emit_space();
      current_paragraph->emit_space();
in html_printer::determine_space which means the return value can
safely be discarded. So, should the function prototype above be:
    void    emit_space     (void);

-- 
albert chin (address@hidden)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]