[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: groff-1.18.1.1/src/devices/grops/ps.cc: bad call to fgets
|
From: |
Werner LEMBERG |
|
Subject: |
Re: groff-1.18.1.1/src/devices/grops/ps.cc: bad call to fgets |
|
Date: |
Thu, 31 Dec 2009 17:03:08 +0100 (CET) |
> I just had a look at source code file
> groff-1.18.1.1/src/devices/grops/ps.cc,
This is oold -- 1.18.1 has been released more than seven years ago.
> char buf[256];
> while (fgets(buf, 512, fp) != 0) {
>
> It seems slightly less than optimal to me to allow 512 characters
> into a buffer of size only 256 bytes. Suggest code rework.
Fixed in 2003, version 1.19.
Werner