[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
groff 1.21: accidental GNU make requirement
From: |
Christian Weisgerber |
Subject: |
groff 1.21: accidental GNU make requirement |
Date: |
Tue, 15 Mar 2011 15:44:45 +0100 |
User-agent: |
Mutt/1.4.2.3i |
groff 1.21 requires GNU make to build, because it accidentally depends
on MAKEOVERRIDES now.
We must not pass MDEFINES recursively down to the sub-makes started
in src/libs/gnulib, because that directory has its own values for
top_srcdir etc. and overriding those from the command line will
cause the build to fail. Currently, MAKEOVERRIDES will prevent the
recursive passing of those overrides with GNU make, but not with
other make(1) implementations.
(If you want to reproduce the build failure with GNU make, just
delete MAKEOVERRIDES from MDEFINES.)
The fix below may be enough. It looks like all targets that require
MDEFINES set them explicitly anyway, so we shouldn't need to set
MDEFINES on the top level.
--- Makefile.in.orig Tue Mar 15 01:08:46 2011
+++ Makefile.in Tue Mar 15 01:19:09 2011
@@ -686,7 +686,7 @@ subdir=src/roff/troff
$(TARGETS):
- @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) do=$@ $(dodirs)
+ @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) do=$@ $(dodirs)
dot: FORCE
@$(ENVSETUP); \
--
Christian "naddy" Weisgerber address@hidden
- groff 1.21: accidental GNU make requirement,
Christian Weisgerber <=