[bug #43569] Fix for compile warnings with gcc 4.6.3

[Ingo Schwarze]

Follow-up Comment #1, bug #43569 (project groff):

I quite strongly disagree with these proposed changes.

Adding useless variables (like FILE* foo in post-html.cpp) harms readability
and hinders code audits because people reading the code will have to figure
out that these variables are unused before being able to understand the code. 
Besides, some compilers warn about variables assigned to but never read, so
this just shifts the nagging elsewhere.

Besides, i suspect this is a case of "the compiler warns, so add some code to
make it shut up" without bothering to actually understand the code at hand. 
That kind of a code audit is worse than no code audit at all because it can
hide real bugs that might otherwise be found more easily by future auditors.

So i suggest to close this bug report as invalid.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43569>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/