[bug #51608] [PATCH] om.tmac-u: Fix some mistakes, fix one bug

[G. Branden Robinson]

Follow-up Comment #1, bug #51608 (project groff):

I've fixed all but a few of these problems; unfortunately the ones that remain
are probably exactly the ones that got Bjarni's attention because they make
groff spew warnings.

<pre>
@@ -221,6 +221,9 @@ end
 .ds PDFHREF.TEXTCOL.DEFAULT 0.0 0.3 0.9
 .nr PDFHREF.VIEW.LEADING.C 3i
 .nr PDFHREF.VIEW.LEADING.T 1i
+.if !r PDFHREF.VIEW.LEADING \{\
+.    nr PDFHREF.VIEW.LEADING 0
+.\}
 .nr PDFHREF.VIEW.LEADING.H \n[PDFHREF.VIEW.LEADING]
 \#
 \# ====================================================================
</pre>

That seems like it's asking for trouble; if anything ever dereferences the
PDFHREF.VIEW.LEADING or PDHREF.VIEW.LEADING.H registers before redefining
them, and if they do what their names suggest, the resulting text will be "set
solid" with no interline spacing. Won't it?

<pre>
@@ -264,6 +267,42 @@ end
 .nr #L_MARGIN \n[.o]  \" Tabs, etc require #L_MARGIN
 .cflags 4 /\[en]      \" So slash and en-dashes get broken
 \#
+\# DEFINE UNDEFINED MACROS AND REGISTERS
+\#
+.if !d AUTO_RELOCATE_TOC \{\
+.    de AUTO_RELOCATE_TOC
+.    .
+.\}
+.
+.if !d BREAK_QUOTE \{\
+.    de BREAK_QUOTE
+.    .
+.\}
+.
+.if !d END \{\
+.    de END
+.    .
+.\}
+.
+.if !d INDENT_REFS \{\
+.    de INDENT_REFS
+.    .
+.\}
+.
+.if !d PDF_LINK_COLOR \{\
+.    de PDF_LINK_COLOR
+.    .
+.\}
+.
+.if !d pdfview \{\
+.    de pdfview
+.    .
+.\}
+.
+.if !r #EN_Q_AUTOLEAD \{\
+.    nr #EN_Q_AUTOLEAD 0
+.\}
+\#
</pre>

I'd like to run these by Peter Schaffter.  There seems to be some assumption
that pdf.tmac or pdfmark.tmac will already be loaded.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51608>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/