bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #59573] typesetting.mom: traps are not initialised (set, planted)


From: G. Branden Robinson
Subject: [bug #59573] typesetting.mom: traps are not initialised (set, planted)
Date: Mon, 30 Nov 2020 05:02:10 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Update of bug #59573 (project groff):

                Category:                    Core => Macro - mom            
                  Status:                    None => Confirmed              
             Assigned to:                    None => PTPi                   

    _______________________________________________________

Follow-up Comment #1:

Confirmed.  These were latent problems, exposed by my recent commit
e3b909eda11419daaf9e1ff028defc0e972ac827 (17 November).

Here's the function in question:


$ sed -n '/::change_trap/,/^}$/p' src/roff/troff/div.cpp
void top_level_diversion::change_trap(symbol nam, vunits pos)
{
  for (trap *p = page_trap_list; p; p = p->next)
    if (p->nm == nam) {
      p->position = pos;
      return;
    }
  error("cannot move unplanted trap macro '%1'", nam.contents());
}


Before my change, an attempt to .ch an unplanted macro would simply fall off
the end of this for loop and return without changing anything, so I'm
reasonably confident this is exposing an actual problem.

Assigning to Peter for his thoughts.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59573>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]