[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #61144] [refer] bad validation of list in indexed biblography file
From: |
G. Branden Robinson |
Subject: |
[bug #61144] [refer] bad validation of list in indexed biblography file |
Date: |
Sat, 11 Sep 2021 16:29:33 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #61144 (project groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.23.0
_______________________________________________________
Follow-up Comment #1:
commit 3f94abf4072e46f1f2e434a0b3582961113991af
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sun Sep 12 05:30:07 2021 +1000
[libbib]: Stop throwing spurious diagnostic.
* src/libs/libbib/index.cpp (index_search_item::get_invalidity_reason):
Don't complain about about a last list element being nonnegative if
the list size was zero in the first place, as can happen with an empty
index. More seriously from a language standpoint, avoid reading
through a negative array index (this can escape a compiler's attention
because we're reading from the midst of a heap-allocated or `mmap()`ed
region, but it's still a code smell).
Fixes <https://savannah.gnu.org/bugs/?61144>.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61144>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/