[bug #61439] [tmac]: test "an_inner-footer-abbreviation-works.sh" fails

[Bjarni Ingi Gislason]

Follow-up Comment #2, bug #61439 (project groff):


[comment #1 comment #1:]
[...]

> I need more to go on.  What is in the test log file?  It should be in your
build tree:
> 
> tmac/tests/an_inner-footer-abbreviation-works.sh.log
> 

Yes, you need more to go on.
  You need information (and thinking) but primarily from
yourself.

 This is there
---cut---
testing long inner footer with sufficient space to set it
testing long inner footer with insufficient space to set it
testing for graceful behavior when TH has no 3rd argument
...FAILED
FAIL tmac/tests/an_inner-footer-abbreviation-works.sh (exit status: 1)
---cut ---

> I have a suspicion that your personal groff branch is setting the CHECKSTYLE
register to a nonzero value, perhaps in tmac/man.local or tman/an.tmac.
> 

  The change is in "git/groff/tmac/an.tmac" among other additions of
mine.

> If you've made such a change, the responsibility is similarly on you to
change the tests to update their expectations.
> 

  No, it is not.  The defect is in the test code, not in the
environment of the user.  It is your expectation that is wrong, not
that of any other user.

  If a test fails by returning a value different from zero, it
may be expected that the observer investigates the cause, if he knows
how, in my case by issuing

<definition of the path to test-groff> sh -x
an_inner-footer-abbreviation-works.sh

> If I'm correct, this bug should be closed as invalid.  If I'm not, I
_definitely_ need more information.

###

  Your issue now is similar to the bug report

 #58164] First html-test fails when a non-utf-8 charmap is used

where you deny a general solution, but then later did change the code
to fulfil your own constraints.

---cut---
(commit
f51cf27208e70ccb60afc4a245f293a0146f77ed
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Oct 28 00:00:33 2021 +1100

    [tests]: Fix portability problems.

[...]

    * src/roff/groff/tests/smoke-test_html_device.sh: Stop trying to set
      $LC_CTYPE to "C.UTF-8"; some systems don't support this
expediency.
      Skip the test if the tester hasn't configured the environment
      adequately.
---cut---


  An update of my proposal was put forward in

https://lists.gnu.org/archive/html/groff/2020-11/msg00138.html
(Subject: Testing the test)

  I later reduced the cases to be tested in my repository.

  Fact is: that test does not need any locale, "groff" handles that.

  My current example (removing irrelevant lines):

echo "testing -k -Thtml" >&2
printf '\303\241' | "$groff" -KUTF-8 -Thtml | grep -qx '<p>&aacute;</p>'

# We test compatibility-mode HTML output somewhat differently since
# preconv only emits groffish \[uXXXX] escapes for non-ASCII codepoints.
echo "testing -C -k -Thtml" >&2
printf "\('a" | "$groff" -C -k -Thtml | grep -qx '<p>&aacute;</p>'

###

  "The problems of the real world are primarily those you are
left with when you refuse to apply their effective solutions."

Page xxxviii in:

On the Cruelty of Really Teaching Computing Science

Edsger W. Dykstra (Dijkstra)

SIGCSE Bulletin 1989, 21(1), pages xxv-xxxix.
Also "www.cs.utexas.edu/users/EWD/"
#

        It is necessary to consider all consequences of
        the proposed action in all states of nature.

There are lots of consequences of any given action.  Many of the
problems of society today are at least partly due to the failure
to realize that the "obvious" action taken had so many bad side
effects.

Herman Rubin on the Usenet forum "misc.education.science".
#


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61439>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/