Re: segfault

[Pavel Roskin]

Hi, Igor!

> I have sent this message earlyer this morning, but i do not think it
> showed up on the list because i was not subscribed, so i decieded to
> subscribe to the list and send it again. I appologize if someone got
> it twice

You can check the list archives http://mail.gnu.org/pipermail/bug-grub/
and see that it's already your third message on the same topic.  You don't
have to subscribe to the list to post messages, not to mention that you
don't need it to read the archives.

It's a good style to send a copy to everybody in the discussion.  Most
people respect this convention, at least in this list.  You don't need to
ask it.

> I just instelled grub-0.90 and weirdness started to happen...

Please always mention the OS you are using.  Maintainers should not have
to guess it from your mutt version.

Anyway, I could reproduce the segfault on GNU/Linux (RedHat 7.1) and CVS
version of GNU GRUB.

> grub> terminal serial
> Segmentation fault

This command is sufficient.

> Program received signal SIGSEGV, Segmentation fault.
> 0x804a23a in serial_checkkey () at asmstub.c:961
> 961       FD_SET (serial_fd, &fds);

One important observation at this point:

(gdb) p serial_fd
$1 = -1

The solution would be to put more checks to prevent users from using the
serial connection before the device is opened.  This seems to be a problem
specific to the GRUB shell.

Are you ready to make a patch?

-- 
Regards,
Pavel Roskin