Re: [bug patch] "md5crypt" command is not built in

[Jochen Hoenicke]

On Jul 21, address@hidden (YAMAGUCHI Shingo ) wrote:
> Hello.
> 
> I fixed bug
> 
>   "md5crypt" command is not built in
> 
> and made fix patch.

Thanks for the report and the detailed analysis.  However, the patch
should be handled differently: The --disabled-xxx switches are there
to minimize the size of stage2, while there are no reasons to minimize
the size of the grub shell.  So the grub shell should have everything
enabled.

I checked in this patch:

RCS file: /cvsroot/grub/grub/ChangeLog,v
retrieving revision 1.425
diff -u -r1.425 ChangeLog
--- ChangeLog   2001/07/13 11:51:24     1.425
+++ ChangeLog   2001/07/26 13:23:29
@@ -1,3 +1,11 @@
+2001-07-26  Jochen Hoenicke  <address@hidden>
+
+       * stage2/Makefile.am (libgrub_a_CFLAGS): Enable USE_MD5_PASSWORDS
+       for libgrub.  Previously that was implicitly done by configure.in
+       until the patch from 2001-07-04, which moved that flag from CFLAGS
+       to FSYS_CFLAGS.  Reported by YAMAGUCHI Shingo
+       <address@hidden>
+
 2001-07-13  OKUJI Yoshinori  <address@hidden>
 
        * util/grub-install.in (convert): Recognize the naming scheme
Index: stage2/Makefile.am
===================================================================
RCS file: /cvsroot/grub/grub/stage2/Makefile.am,v
retrieving revision 1.35
diff -u -r1.35 Makefile.am
--- stage2/Makefile.am  2001/07/04 07:33:48     1.35
+++ stage2/Makefile.am  2001/07/26 13:23:29
@@ -20,6 +20,7 @@
 libgrub_a_CFLAGS = $(GRUB_CFLAGS) -I$(top_srcdir)/lib \
        -DGRUB_UTIL=1 -DFSYS_EXT2FS=1 -DFSYS_FAT=1 -DFSYS_FFS=1 \
        -DFSYS_MINIX=1 -DFSYS_REISERFS=1 -DFSYS_VSTAFS=1 \
+       -DUSE_MD5_PASSWORDS=1 \
        -DSUPPORT_SERIAL=1 -DSUPPORT_HERCULES=1 -fwritable-strings
 
 # Stage 2 and Stage 1.5's.
Index: stage2/Makefile.in
===================================================================
RCS file: /cvsroot/grub/grub/stage2/Makefile.in,v
retrieving revision 1.51
diff -u -r1.51 Makefile.in
--- stage2/Makefile.in  2001/07/04 07:33:48     1.51
+++ stage2/Makefile.in  2001/07/26 13:23:30
@@ -111,6 +111,7 @@
 libgrub_a_CFLAGS = $(GRUB_CFLAGS) -I$(top_srcdir)/lib \
        -DGRUB_UTIL=1 -DFSYS_EXT2FS=1 -DFSYS_FAT=1 -DFSYS_FFS=1 \
        -DFSYS_MINIX=1 -DFSYS_REISERFS=1 -DFSYS_VSTAFS=1 \
+       -DUSE_MD5_PASSWORDS=1 \
        -DSUPPORT_SERIAL=1 -DSUPPORT_HERCULES=1 -fwritable-strings