GRUB "embed" function for stage1.5 broken??

[erich]

In putting in some extra consistency checks for the GRUB shell
installer (and for Linux adding BMAP functionality for the stage2),
I seem to have come across an issue...

The "setup" builtin function will try to install a stage 1.5, but
then overwrite it immediately with a stage2.

Is this on purpose, or just broken?

I think I can fix it, unless someone is depending on the current
functionality of "embed".  It seems to not be doing the right thing...
what you'd want it to do is have an extra parameter for where to look
for the "stage2".

So, I'd add an extra parameter to "embed" to make it set the place
to look for the stage2, and fix up the "setup" function to use that
parameter, and if a stage 1.5 is created, don't even try to run the
installer on the stage2.

I.e. why have extra blockmaps, especially ones that depend on the
locations of files in the filesystem, if you don't need them?

In this configuration, if you have a stage 1.5, you'd never need to
get a block-map that refers to files in the filesystem anyway.

--
    Erich Stefan Boleyn     <address@hidden>     http://www.uruk.org/
"Reality is truly stranger than fiction; Probably why fiction is so popular"