Re: netboot update is in progress

[Rick]

>> Ok, I have checked in my working set to the CVS right now. So the
>> CVS version now uses network drivers derived from the latest
>> version of Etherboot, 5.0.5. I checked only nbgrub with the
>> eepro100 driver and it worked quite well.

Okuji,

Thank you, thank you, thank you for working on this.
I use GRUB and Etherboot heavily.

I've tried the CVS version of GRUB with a Tulip 21140 card (which was
previously unsupported by GRUB's netboot) and it works well.

I've found one trivial bug, though:

--- netboot/misc.c.orig Fri Jan  4 01:02:04 2002
+++ netboot/misc.c      Fri Jan  4 01:02:26 2002
@@ -221,7 +221,7 @@
       if (val < 0 || val > 255)
        return 0;

-      if (*p++ != '.')
+      if ( (*p++ != '.') && (i != 3) )
        return 0;

       ip = (ip << 8) | val;



This code is in the inet_aton() function and, without the patch, it does
not recognize an IP address without a final dot.  e.g. "1.2.3.4." is 
recognized but "1.2.3.4" is not.  This affects the ifconfig and tftpserver
commands.

Also, I notice that this code did not come from Etherboot 5.0.5 or
any other version of Etherboot that I can find.  The inet_aton()
function in Etherboot works well.

Is there some more merging to be done?

Rick