Re: [Bug #762] serial terminal can't accept any input

[Ilguiz Latypov]

Okuji,

Thank you for responding to my report.

Isn't there a typo again in parentheses?  I attached the latest diff from
the GRUB repository and the one I submitted.

Ilguiz

===================================================================
RCS file: /cvsroot/grub/grub/stage2/serial.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- grub/grub/stage2/serial.c   2002/06/11 16:36:54     1.6
+++ grub/grub/stage2/serial.c   2002/06/29 20:35:27     1.7
@@ -80,7 +80,7 @@
 int
 serial_hw_fetch (void)
 {
-  if (inb ((serial_hw_port + UART_LSR) & UART_DATA_READY) == 0)
+  if (inb ((serial_hw_port + UART_LSR) & UART_DATA_READY))
     return inb (serial_hw_port + UART_RX);
 
   return -1;

===================================================================


===================================================================
RCS file: /usr/local/cvsroot/grub/stage2/serial.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 serial.c
--- serial.c    22 Jun 2002 00:44:29 -0000      1.1.1.3
+++ serial.c    27 Jun 2002 02:54:52 -0000
@@ -80,7 +80,7 @@
 int
 serial_hw_fetch (void)
 {
-  if (inb ((serial_hw_port + UART_LSR) & UART_DATA_READY) == 0)
+  if (inb (serial_hw_port + UART_LSR) & UART_DATA_READY)
     return inb (serial_hw_port + UART_RX);
 
   return -1;

===================================================================


On Sat, 29 Jun 2002 address@hidden wrote:

> Thanks for your report. I've fixed it.