[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-grub] color problem in CVS grub

From: Yoshinori K. Okuji
Subject: Re: [Bug-grub] color problem in CVS grub
Date: Thu, 22 Aug 2002 11:33:29 +0900
User-agent: Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (Unebigoryƍmae) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI)

Thank Jason. You did a nice hack. I think the remaining problem is
about how to write ChangeLog. You should notice that the style of your
ChangeLog entry is a bit different from that of mine. Please match
yours to mine. For example:

+   * stage2/term.h:
+   changed highlight state code for hercules, console and serial
+   state was 0 - normal or 1 - highlight.
+   state is now defined using an typedef enum color_state,
+   which has:

It's better to write that kind of descriptions, before any item, after
the first line which contains a date and your name.

+   * stage2/hercules.c:
+   (herc_highlight_state): removed

Don't fold lines unnecessarily. Also, make the description a valid
English sentence, that is, capitalize the first character whenever
appropriate, and append a period. So, that should be written like

        * stage2/hercules.c (herc_hilight_state): Removed.

+   (console_standard_color): New variable
+   (console_color_state): New variable

That is too verbose. This is better:

        (console_standard_color): New variable.
        (console_color_state): Likewise.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]