[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-grub] color problem in CVS grub

From: Yoshinori K. Okuji
Subject: Re: [Bug-grub] color problem in CVS grub
Date: Thu, 22 Aug 2002 14:42:48 +0900
User-agent: Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (Unebigoryƍmae) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI)

At Thu, 22 Aug 2002 14:56:26 +1000,
Jason Thomas wrote:
> 2002-09-20  Jason Thomas <address@hidden>
>    changed highlight state code for hercules, console and serial.

Capitalize that line.

>    state was 0 - normal or 1 - highlight.
>    state is now defined using an enum called color_state.

"The state" would be more appropriate. Also, it would be better to
insert an extra newline after that paragraph, for readability.

>    Updated function prototypes.

Don't paraphrase. List up all the prototypes you modified.

>    * stage2/stage2.c (print_entry, print_border): Set color states using
>    new states.

That is allowed in the GNU Coding Standards, but I prefer this:

        * stage2/stage2.c (print_entry): Set color states using new states.
        (print_border): Likewise.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]