Re: [Bug-grub] [PATCH] Allow appending kernel options directly from the main menu

[Jeremy Katz]

Because I didn't write it and I'm not going to spend a lot of time
reorganizing working code without a good reason? :)  

I'm also not convinced that consolidation with 'e' would do much to help
things -- most of the code for the 'a' case is to handle actually going
past the kernel and just displaying the arguments for editing as opposed
to showing the whole line.  The shared code is largely allocating the
new_heap and finding the config entry, but similar bits are already
duplicated in most of the cases of run_menu() just due to the slight
variations needed for each one.

Cheers,

Jeremy

On Tue, 2002-10-01 at 17:52, Jason Thomas wrote:
> if this is almost the same as 'e' than why all the duplication?
> 
> On Tue, Oct 01, 2002 at 05:16:11PM -0400, Jeremy Katz wrote:
> > The following patch lets users to directly edit the kernel command line
> > by pressing 'a' at the grub menu.  This makes it significantly easier
> > for users to do things such as boot in single user mode or pass kernel
> > options for debugging.
> > 
> > Patch is against current CVS.