[bug #52637] ZFS enhancement suggestions?

[lundman]

URL:
  <http://savannah.gnu.org/bugs/?52637>

                 Summary: ZFS enhancement suggestions?
                 Project: GNU GRUB
            Submitted by: lundman
            Submitted on: Mon 11 Dec 2017 05:30:52 AM UTC
                Category: Filesystem
                Severity: Major
                Priority: 5 - Normal
              Item Group: Feature Request
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: Git master
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:


Hello GRUB!

So I ported GRUB's ZFS support to U-boot in 2012, and have gone back to
refresh it today. Excellent work, and thanks, on the new features, like lz4,
and raidz booting!

While doing that work, I came across of few tiny things that perhaps would be
appreciated in GRUB. (nits really..) But if this is just annoying noise, feel
free to close this ticket.

Minor memory leak in rare error case, dmu_read() allocated zapbuf:
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2527

again at line 2598 and line 2639.

The directory listing code here:
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2113
passes the "mze_value" unmolested to (eventually) dnode_get(). But it should
be filtered by ZFS_DIRENT_OBJ() as in:
https://github.com/lundman/u-boot/blob/master/fs/zfs/zfs.c#L2054

( used correctly in the file reading code: )
https://github.com/coreos/grub/blob/d3fd939f18446b05d1d5456f23823498a1eb3fb4/grub-core/fs/zfs/zfs.c#L2847

Which makes listing work here. But it confuses me a little that nobody has
complained that listings do not work correctly in GRUB for non-Solaris pools,
like ZOL?

That is all.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52637>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/