[bug #54811] After running 'configure' with a existing cache, bulid fails with '/symbol.h:36:20: error: #if with no expression'

[Mark Wutzke]

URL:
  <https://savannah.gnu.org/bugs/?54811>

                 Summary: After running 'configure' with a existing cache,
bulid fails with '/symbol.h:36:20: error: #if with no expression'
                 Project: GNU GRUB
            Submitted by: mwutzke
            Submitted on: Wed 10 Oct 2018 11:12:48 AM NZDT
                Category: Compilation
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: 2.02
         Reproducibility: Intermittent
         Planned Release: None

    _______________________________________________________

Details:

When 'configure' (2.0.2 and mainline) is re-executed with an existing autoconf
config.cache, the generated config.h contains the following:


  config.h:#define HAVE_ASM_USCORE 


which then generates a compile time error like the following:


In file included from ../include/../include/grub/cache.h:23:0,
                 from symlist.h:2:
../include/grub/symbol.h:36:20: error: #if with no expression
 #if HAVE_ASM_USCORE
                    ^
Makefile:41364: recipe for target 'symlist.c' failed


The attached patch resolves this by moving the setup of HAVE_ASM_USCORE in
grub_ASM_USCORE, to be outside the AC_CACHE_VAL macro, which is not supposed
to have side effects.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 10 Oct 2018 11:12:48 AM NZDT  Name:
0001-grub-Allow-configure-be-re-run-with-cache.patch  Size: 1KiB   By: mwutzke
Proposed patch
<http://savannah.gnu.org/bugs/download.php?file_id=45172>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54811>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/