[bug #60067] grub-install --core-compress option broken (trivial fix)

[INVALID.NOREPLY]

URL:
  <https://savannah.gnu.org/bugs/?60067>

                 Summary: grub-install --core-compress option broken (trivial
fix)
                 Project: GNU GRUB
            Submitted by: ratter
            Submitted on: Tue 16 Feb 2021 03:52:43 PM UTC
                Category: Installation
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 
                 Release: 2.02
         Discussion Lock: Any
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

Invoking ‘grub-install’ with “--core-compress <anything>” produces the
error message “Option should have been recognized!?”.


$ grub-install --core-compress none

  grub-install: --core-compress: (PROGRAM ERROR) Option should have been
recognized!?
  Try 'grub-install --help' or 'grub-install --usage' for more information.
  
$ grub-install --core-compress bogus

  grub-install: --core-compress: (PROGRAM ERROR) Option should have been
recognized!?
  Try 'grub-install --help' or 'grub-install --usage' for more information.


*Fix:* In the file ‘util/grub-install-common.c’, at the beginning of the
function ‘grub_install_parse()’, replace the character constant ‘C’ in
the ‘case’ statement with the macro
‘GRUB_INSTALL_OPTIONS_INSTALL_CORE_COMPRESS’.


int
grub_install_parse (int key, char *arg)
{
  switch (key)
    {
    /* case 'C': */
    case GRUB_INSTALL_OPTIONS_INSTALL_CORE_COMPRESS:
        …


Program output after the fix, with the same command line as before:

$ grub-install --core-compress bogus

  grub-install: error: Unknown compression format bogus.

(Passing “--core-compress bogus” was just the quickest way of
demonstrating that the option parsing error was fixed.  It also seems to be
functioning as intended:

$ grub-install --core-compress none --verbose <other-options…> <device>

…invokes “grub-mkimage --compression none”, as expected.)




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60067>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/