bug-gsl
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gsl] Contribution: Hermite polynomials, functions etc.


From: Konrad
Subject: Re: [Bug-gsl] Contribution: Hermite polynomials, functions etc.
Date: Mon, 09 Dec 2013 22:17:25 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

Hi Rhys and all,

finally I got around to finishing up on the issues with my contribution.
So please find attached the documentation (specfunc-hermite.texi),
header file (gsl_sf_hermite.h), precision tests (test_hermite.c) and of
course the main code (gsl_sf_hermite.c).
As in my last message on the documentation I should mention the
following points.
The introduction is a little longer than in most other chapters, this is
on purpose since I figured that it is easier for one of you to throw
parts of it out than to extend it. So feel free to shorten it, the only
piece of information I find noteworthy is the fact that the Hermite
functions are eigenfunctions of the Fourier transform. This makes them
very useful and is often forgotten.
Since I'm not very well versed in Texinfo, I couldn't get the greek
character psi on the index, so if somebody knows how to fix this, please
do, the corresponding line is commented right now.
Also, the attached file can be compiled on its own, but I've added
comments where the part relevant for the GSL-manual begins and ends.
The other files are hopefully sufficiently similar to the GSL-standards.
Especially, the functions now include rough estimates of the numerical
errors. Also, some overflow control is implemented throughout the code
that could be exploited further in the future if necessary.
Hope this helps, please feel to contact me with any issues that may arise!

Cheers,
Konrad



> 
>> There's a piece of code I'd like to contribute to your great library.
>> It consists of a few functions to compute Hermite polynomials, Hermite
>> functions and their respective derivatives, please see the attachment
>> gsl_hermite.c.
> 
> Thank you!  From a quick pass there are a couple of little things:
> 
> 1) We need a set of gsl_sf_hermite.h declarations.  Should this just
> be all non-static functions declared within your gsl_hermite.c file?
> Should the single-point functions like gsl_sf_hermite_prob and
> gsl_sf_hermite_prob_der be publicly exposed too?
> 
> 2) We need to get the test cases in gsl_hermite_test.c using the GSL
> test infrastructure.  You can see an example of this within
> specfunc/test_airy.c.  I think getting the test code ported over
> should be relatively quick but I'm uncertain what tolerances to use
> given the printf statements in your gsl_hermite_test.c code.
> 
> 3) We'll need to add documentation for the new functions.  These will
> resemble content like doc/specfunc-airy.texi.  Much of the necessary
> content appears in your email and can be written once we've got a
> gsl_sf_hermite.h in hand from item 1.
> 
> These three things don't have to happen all in one commit, but we
> should get them in place before the next release.  I must admit I
> don't know when that is planned.
> 
> The code looks very nice from a quick browse.  Thank you again.
> 
> - Rhys
> 

Attachment: specfunc-hermite.texi
Description: Text Data

Attachment: gsl_sf_hermite.c
Description: Text Data

Attachment: gsl_sf_hermite.h
Description: Text Data

Attachment: test_hermite.c
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]