bug-gsl
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gsl] Erroneous use of GSL_ERROR_NULL instead of GSL_ERROR macro


From: Matthias Sitte
Subject: [Bug-gsl] Erroneous use of GSL_ERROR_NULL instead of GSL_ERROR macro
Date: Thu, 09 Jul 2015 22:16:51 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

Hi list,

in reference to my previous email I dug through the whole code base, checking
each function that the 'git grep -n -p "GSL_ERROR_NULL"' returned.  Thankfully,
only a couple of more functions turned up which use GSL_ERROR_NULL instead of
GSL_ERROR. Although this might not seem relevant at first, remember that
GSL_SUCCESS equals to 0 as does NULL returned by GSL_ERROR_NULL, so there's no
way of knowing that those functions might fail if you use a custom error handler
which doesn't automatically abort.

Anyway, patch attached. If you prefer pull requests instead, let me know.

Cheers,

  Matthias

Attachment: fix_erroneous_use_of_gsl_error_null_macro.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]