Re: [bug-gsrc] bash

[Brandon Invergo]

Hi Carl,

> "Bash" in the news. I decided to upgrade it to lastest patchlevel , 25.

I just pushed the update.  We'll have to keep an eye on new developments
since patch 25 doesn't 100% fix the problem.

> Easy enough to build it, (after glitch, below). But I can't figure out how to 
> upload it to savannah before my attention span terminates.
>
> Maybe you could give me a few clues.
> Only had to change 2 files, Makefile and sha246sum

My usual update workflow is the following:

1. edit Makefile

2. rarely: update gpg-keyring (see 'keyring' target in
  util/gsrc-maint.mk, which you can include in your config.mk)

    $ make keyring

3. update sha256sums: 

    $ make makesum

4. test the build: 
    
    $ make test-build

5. check in the update (though in the case of a Bash patch update, I do
   this manually via "bzr commit" since the following way won't
   correctly add the patch number to the commit message): 

    $ make ci

6. push to savannah: 
 
    $ bzr push

> The glitch I mentioned:
> [install] Preparing staging area
> rm -fr /opt/gsrc/packages/bash-4.3-25 -DEST
> rm: invalid option -- 'D'
> Try 'rm --help' for more information.
> make: *** [prepare-install] Error 1
> ../../gar.lib.mk:646: recipe for target 'prepare-install' failed
>
> You see the space before "-DEST"
> I was surprized to find this was because the line in Makefile:
> PATCHNUM = 25
> had a trailing space! Surprized me; a bug in make?

Weird, I hadn't encountered that before but I can confirm that it
happens for me too.  It strikes me not as a bug but as a side effect of
not needing to enclose variable values in quotes; the value includes
everything up to the newline.  We could use Make's 'strip' function to
remove the whitespace when such compound strings are built (in this
case, "packageDESTDIR", line 623 in gar.lib.mk).  It doesn't look like
there will be many places that need such a change (mainly wherever
GARNAME and GARVERSION are used in gar.mk and gar.lib.mk).  I'll work on
that. 

-brandon


-- 
Brandon Invergo
http://brandon.invergo.net

pgpKTlmBjWQw_.pgp
Description: PGP signature