Re: libguile/socket.c

[Neil Jerram]

address@hidden (Ludovic Courtès) writes:

> Hi,
>
> Neil Jerram <address@hidden> writes:
>
>> I wonder if that's because it's generally concerned about
>> uninitialized variables, or because it's noticed the apparent bug in
>> scm_c_make_socket_address, which does nothing with its address_size
>> parameter and instead has another size_t variable on the stack.
>
> It's a bug in `scm_c_make_socket_address ()'.  I apologize for this.

Thanks for confirming this.  I'll make the change in CVS.

>>   soka = scm_fill_sockaddr (scm_to_ushort (family), address, &args, 1,
>>                          "scm_c_make_socket_address", &address_size);
>                                                          ^^
> Here it should read `address_size', not `&address_size'.

Indeed, thanks.

        Neil