[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14792: Error in manual "(guile-2) Object Properties"
From: |
Mark H Weaver |
Subject: |
bug#14792: Error in manual "(guile-2) Object Properties" |
Date: |
Fri, 05 Jul 2013 12:37:47 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Hi David,
David Kastrup <address@hidden> writes:
> The manual states in "Object Properties":
>
> A single object property created by `make-object-property' can
> associate distinct property values with all Scheme values that are
> distinguishable by `eq?' (including, for example, integers).
>
> Integers are not documented to be reliably distinguishable by eq? (which
> means that equal integers might not be eq).
Indeed, good point!
I think we should change object-properties to use 'eqv?' hash operations
instead of 'eq?'. The only advantage to 'eq?' is a marginal efficiency
benefit, but that's no doubt lost in the noise, not only from the hash
table operations but from the use of fat mutexes.
The only functional difference between Guile's 'eq?' and 'eqv?' is that
'eq?' is not reliable on numbers. Our manual has been telling people
for years that integers can be used as keys for object properties.
Therefore, we should make it so. IMO, anyway.
What do other people think?
Mark
- bug#14792: Error in manual "(guile-2) Object Properties", David Kastrup, 2013/07/04
- bug#14792: Error in manual "(guile-2) Object Properties",
Mark H Weaver <=
- bug#14792: Error in manual "(guile-2) Object Properties", Ludovic Courtès, 2013/07/06
- bug#14792: Error in manual "(guile-2) Object Properties", Mark H Weaver, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", David Kastrup, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", Mark H Weaver, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", David Kastrup, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", Mark H Weaver, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", David Kastrup, 2013/07/16
- bug#14792: Error in manual "(guile-2) Object Properties", Ludovic Courtès, 2013/07/16
bug#14792: Actually, this discussion is moot, David Kastrup, 2013/07/27