[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15798: Bad variable name "noreturn" in libguile/throw.h
From: |
Jack Howarth |
Subject: |
bug#15798: Bad variable name "noreturn" in libguile/throw.h |
Date: |
Mon, 4 Nov 2013 20:48:32 -0500 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Nov 04, 2013 at 07:48:29PM -0500, Mark H Weaver wrote:
> Matt Sicker <address@hidden> writes:
> > In the function scm_ithrow, the parameter "int noreturn" is given. Now
> > this works fine normally, but if stdnoreturn.h is included before
> > throw.h (or libguile.h more likely), then this causes a compilation
> > error. In throw.c, noreturn is even marked as an unused variable, so
> > this is even more annoying! I recommend using "no_return" to prevent
> > any namespace conflicts.
>
> Fixed in stable-2.0. Thanks for the report.
>
> http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commit;h=36c40440078c005cd5e239cca487d29f6f60007d
>
> Mark
>
>
What is the motivation to change from attribute (noreturn) to attribute
(__noreturn__). Xcode 5.0
has /Library/Developer/CommandLineTools/usr/lib/clang/5.0/include/stdnoreturn.h
with...
/*===---- stdnoreturn.h - Standard header for noreturn macro ---------------===
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*
*===-----------------------------------------------------------------------===
*/
#ifndef __STDNORETURN_H
#define __STDNORETURN_H
#define noreturn _Noreturn
#define __noreturn_is_defined 1
#endif /* __STDNORETURN_H */
I only see the use of __attribute__((__noreturn__)) in /usr/include/c++/4.2.1/
on darwin13 (aka libstdc++). The
/Library/Developer/CommandLineTools/usr/lib/c++/v1 directory
for libc++ only shows the usage of __attribute__((noreturn)) and not any usages
of
__attribute__((__noreturn__)).
Jack
ps Also see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15807.