[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds pro
From: |
Ludovic Courtès |
Subject: |
bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly |
Date: |
Fri, 23 Dec 2022 11:53:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Josselin,
Josselin Poiret <dev@jpoiret.xyz> skribis:
> Here is hopefully the last reroll of this patchset. First of all, I did not
> include the gnulib patch again because it still applies cleanly and it is
> extremely large, but it should be applied before those 3 patches.
Yay!
> The first two patches should be applied on the current major release, while
> the
> third one should be applied on the next major release to finish the migration
> to
> spawn.
I pushed it to ‘wip-posix-spawn’ along with fixups I’m proposing, mostly
along the lines of what I suggested in
<https://issues.guix.gnu.org/52835#18>:
• Avoiding the extra ‘fork’ in ‘system*’ upon error;
• Keep ‘scm_spawn_process’ internal.
I also added Andrew Whatson’s patch from
<https://issues.guix.gnu.org/59321>.
If that’s fine with you, I can squash the “fixup!” commits and merge the
branch. Let me know!
Earlier we agreed it’d be nice to expose ‘spawn*’/‘primitive-spawn’. I
still think it’s a good idea, but the interface would need some work IMO
to be more generally useful. In essence, we could provide something
similar to ‘fork+exec-command’ in the Shepherd, where one can pass
environment variables, stdin/stdout/stderr, etc., all that with keyword
arguments and reasonable defaults.
It’s a bit of extra work though so we can discuss that later,
separately.
Thank you!
Ludo’.
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Josselin Poiret, 2022/12/11
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Ludovic Courtès, 2022/12/12
- bug#52835: [PATCH v6 0/3] Move spawning procedures to posix_spawn., Josselin Poiret, 2022/12/22
- bug#52835: [PATCH v6 1/3] Add spawn*., Josselin Poiret, 2022/12/22
- bug#52835: [PATCH v6 3/3] Move popen and posix procedures to spawn*., Josselin Poiret, 2022/12/22
- bug#52835: [PATCH v6 2/3] Make system* and piped-process internally use spawn., Josselin Poiret, 2022/12/22
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly,
Ludovic Courtès <=
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Josselin Poiret, 2022/12/23
- bug#52835: [PATCH v7 1/2] Add spawn* and spawn., Josselin Poiret, 2022/12/23
- bug#52835: [PATCH v7 2/2] Make system* and piped-process internally use spawn., Josselin Poiret, 2022/12/23
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Ludovic Courtès, 2022/12/25
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Ludovic Courtès, 2022/12/25
- bug#52835: [PATCH 0/2] Fix spawning a child not setting standard fds properly, Ludovic Courtès, 2022/12/25